search

cobrasrock / Skin-Swapper

A fabric mod that allows you to change your in game skin using a simple gui.
GNU General Public License v3.0
29 stars 15 forks source link

[Fabric 1.18.2] Incompatible with First Person Model #36

Closed Peppernose145 closed 1 year ago

Peppernose145 commented 2 years ago

Basic Information

Minecraft version: 1.18.2
Loader: Fabric loader 0.13.3-1.18.2
OS (likely irrelevant): Arch Linux

Mod list is included in the log file accessed via Pastebin or via the attached latest.log

The problem

When the game starts with both Skin Swapper and First Person Model installed, the game gets stuck in a loop of repeatedly reloading resources (Mojang splash screen). When this happens we get the following error every loop:

@Redirect conflict. Skipping firstperson.mixins.json:PlayerRenderMixin->@Redirect::setModelPoseRedirect(Lnet/minecraft/class_1007;Lnet/minecraft/class_742;Lnet/minecraft/class_742;FFLnet/minecraft/class_4587;Lnet/minecraft/class_4597;I)V from mod firstperson with priority 1000, already redirected by skinswapper.mixins.json:preview.PlayerEntityRendererMixin->@Redirect::setModelPoseRedirect(Lnet/minecraft/class_1007;Lnet/minecraft/class_742;)V from mod skinswapper with priority 1100

Relevant Logs

Pastebin Log latest.log

To reproduce

Launch the game with this mod and First Person Model installed

Other notes

The mod works as expected (within the scope of the problem) without the First Person Model mod

bladehorton commented 1 year ago

Ever found a solution to this problem? I am having the same troubles myself

tr7zw commented 1 year ago

Hey, dev of FirstPerson here(since the crash report says it's my mod, due to Skin-Swapper using a higher priority). The crash is because of the redirect here https://github.com/cobrasrock/Skin-Swapper/blob/45ed59980e1222ba9e266ad2a7e7a91c0ff36692/src/main/java/net/cobrasrock/skinswapper/mixin/preview/PlayerEntityRendererMixin.java . There is no reason for Skin-Swapper to redirect the method. Just hook at return/tail and change the settings if required.

cobrasrock commented 1 year ago

fixed by #45