Code is rendered outside header tags

cobrateam / django-htmlmin

HTML minifier for Python frameworks (not only Django, despite the name).

http://pypi.python.org/pypi/django-htmlmin

BSD 2-Clause "Simplified" License

542 stars 73 forks source link

Code is rendered outside header tags #132

Open mina-gaid opened 5 years ago

mina-gaid commented 5 years ago

Code is being compressed and placed outside the header tags. The header tags are still there but empty. Is this a bug or by design?

delizin commented 5 years ago

This is definitely a major issue. I was chasing down my favicon disappearing as well and it took me a little bit to realize that my entire header was suddenly empty.

mina-gaid commented 5 years ago

I contacted one of the maintainers - andrewsmedina. He said he'll fix it and never did. I managed to find the issue and created a merge request but he won't merge and ignore all my messages.

I have no need for this repo anymore but if I need it, I'll be looking for an alternative because this one is dead. There might be another fork thats still going. I'd recommend you Google a bit or ask people on Django's Discord channel.

andrewsmedina commented 5 years ago

@mina-gaid sorry for the delay. But Iḿ not ignoring any one. But is hard to revise a PR that changes more than on behaviour.

I will try to get some time to revise all pending PR's. But, if someone can help revising PR, this help is very welcome.