Open honi opened 12 years ago
Well, the title says it all, introduce some blank lines in a and then some text content. When submitted, after minifying, the first blank line is deleted. If minified again, second blank line is deleted. So on until no blank lines are left before the text content (empty lines at the end don't get deleted).</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/fsouza"><img src="https://avatars.githubusercontent.com/u/108725?v=4" />fsouza</a> commented <strong> 12 years ago</strong> </div> <div class="markdown-body"> <p>Thanks for reporting :)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/fsouza"><img src="https://avatars.githubusercontent.com/u/108725?v=4" />fsouza</a> commented <strong> 12 years ago</strong> </div> <div class="markdown-body"> <p>The logic to not minify <code><textarea></code> is the same for <code><script></code>.</p> <p>This is not desirable:</p> <pre><code class="language-html"><script> $(document).ready(function () { alert("bla"); }); </script></code></pre> <p>But this might be:</p> <pre><code class="language-html"><textarea> Hello world</textarea></code></pre> <p>We should treat these tags separately.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/fsouza"><img src="https://avatars.githubusercontent.com/u/108725?v=4" />fsouza</a> commented <strong> 12 years ago</strong> </div> <div class="markdown-body"> <p>I'm not able to reproduce this issue.</p> <p>I've added a automatized test with the given scenario, but the test passes. Could you please help me here? :)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/fsouza"><img src="https://avatars.githubusercontent.com/u/108725?v=4" />fsouza</a> commented <strong> 11 years ago</strong> </div> <div class="markdown-body"> <p>I believe I'm able to reproduce this now, the test is broken. I will take a look later.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/bernardobarreto"><img src="https://avatars.githubusercontent.com/u/824254?v=4" />bernardobarreto</a> commented <strong> 11 years ago</strong> </div> <div class="markdown-body"> <p>I actually made the test @fsouza added break, using 'html.parser' instead of 'html5lib'.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/fsouza"><img src="https://avatars.githubusercontent.com/u/108725?v=4" />fsouza</a> commented <strong> 11 years ago</strong> </div> <div class="markdown-body"> <p>Actually, the test is wrong. Currently, the test is checking whether the line is removed. We should fix the test, and the behavior.</p> <p>There are seven blank lines in the <a href="https://github.com/cobrateam/django-htmlmin/blob/master/htmlmin/tests/resources/with_textarea_with_blank_lines.html#L10">original file</a>, but six in the <a href="https://github.com/cobrateam/django-htmlmin/blob/master/htmlmin/tests/resources/with_textarea_with_blank_lines_minified.html#L2">minified</a>.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/hrbonz"><img src="https://avatars.githubusercontent.com/u/99708?v=4" />hrbonz</a> commented <strong> 10 years ago</strong> </div> <div class="markdown-body"> <p><code><script></code> and <code><textarea></code> should not be minified, one is script code not html and could have so many different scripting languages inside it and more, the other should be formatted by the creator of the code.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>
Well, the title says it all, introduce some blank lines in a