search

coburnw / python-vxi11-server

A VXI-11 Instrument Server written in Python
27 stars 13 forks source link

fixes to upstream #10

Closed ulda closed 3 years ago

ulda commented 3 years ago

I cherry picked some fixes that are independent from my gpib-bridge work for upstreaming.

b72aea0 will correct the API, so be aware that outside code has to be fixed with regarding to use of encoding/decoding opaque_data, see example code.

feel free to apply.

ulda commented 3 years ago

I added real SRQ support.

coburnw commented 3 years ago

This is going to take me a bit to work thru. Please know i appreciate the work.

coburnw commented 3 years ago

I chose to break your commits into two groups, fixes and srq. It seems that when a pull request is merged into a branch other than default, the requester doesnt get full credit. Obviously im still learning project management on github. I would be happy to accept a new pull request for your srq work, commits c9f9578 thru 8352592 to be merged directly into master so you get the full credit due for your work. Otherwise, i can simply merge from my original attempt.

Secondly, have you given any thought of forking the python-vxi11 project with intent of a pull request for the srq functionality? I took extra effort to minimize modifications to vxi11.py, it might be quite trivial to add your changes. I understand that that project has become rather silent, but it might still be a good way for others to find the srq client for use in their projects.

ulda commented 3 years ago

Hi coburn I wil make another branch and rebase srq support for upstreaming to you . If it works out, i get test time this Friday and gpib0,1 + srq works in real semicon world. And i'd like to get hold of one of our high $ keithley instruments with lan & srq support from my calib lab for a test over the weekend. This should ultimately qualify for upstreaming ... Keep tuned ...

ulda commented 3 years ago

By the way, Maybe you can check https://github.com/ulda/python-vxi11-server/commit/ac86c2d0523c887a9f491dd35d92c7f641915522 This is invasive. But I think you puzzled on this fir long , too?

coburnw commented 3 years ago

Ah-ha. So THATS how thats supposed to work. One for the fix pile. Thanks!