search

cobyism / dciy

Do Continuous Integration Yourself — a simple, open source CI server.
98 stars 10 forks source link

GitHub:Enterprise support #29

Closed smashwilson closed 10 years ago

smashwilson commented 10 years ago

We've got a GitHub:Enterprise instance and it'd be neat to be able to use DCIY with it. I think it makes sense to support Enterprise, especially since DCIY is mostly useful for non-public repositories.

If an ENTERPRISE_HOST environment variable is set, DCIY will give you a dropdown for the hostname when you're creating or editing a Project, letting you choose between the enterprise host, github.com, or whatever the project is already using (so it doesn't get all weird if you change the setting around):

dciy-enterprise-dropdown

cobyism commented 10 years ago

Nice! Cool idea! On this point though, is it worth making the ENV variable a comma separated list of enterprise instances (in case people have more than one they connect to)? or is that overkill/unecessarily complex?

smashwilson commented 10 years ago

Probably an uncommon need, but really easy to support. It's now ENTERPRISE_HOSTS.

cobyism commented 10 years ago

Awesome. I’m :+1: on this when you are, so merge away :grin:

smashwilson commented 10 years ago

Great, thanks for the review!