search

cobyism / dciy

Do Continuous Integration Yourself — a simple, open source CI server.
98 stars 10 forks source link

In _master_, DCIY build completes successfully without rspec results #32

Open jwilm opened 10 years ago

jwilm commented 10 years ago

There is a problem building DCIY master branch when running DCIY on master. Output from rspec is not shown, and the build completes as if bundle exec rake spec returned successfully without doing anything. Here is the output from DCIY:

screen shot 2014-01-10 at 8 44 48 am

This does not seem to happen when cloning and building a fresh copy of DCIY from terminal, although that gets a lot of rspec errors due to the security token not being set.

Sorry I don't have time to look into this further this morning. My next steps would be testing against another code base to see if that builds properly, and then doing a bisect to see where this was introduced if it's not just a problem with our own build configuration.

cobyism commented 10 years ago

I suspect this has something to do with dciy.toml, and might be another symptom of it just not being that great a way of approaching the specification of buildsteps :confused:

smashwilson commented 10 years ago

That's strange. @jwilm, are you still seeing this? I can't seem to reproduce it now:

dciy-clean-build

Or even by building master off of your fork, which (properly) fails due to pending migrations:

dciy-fork-build

The build should actually blow up descriptively if the CI commands are empty for whatever reason. The only way it wouldn't is if rspec or bundler silently failed, with no output and a 0 exit code...