search

cobyism / gridism

A simple responsive CSS grid.
http://pages.cobyism.com/gridism
MIT License
658 stars 85 forks source link

support no-stacking-on-mobiles class on the grid element #15

Closed palominoz closed 10 years ago

palominoz commented 10 years ago

issue #14

cobyism commented 10 years ago

:+1: Sweet! Yeah, if you make that change to the direct child selector you mentioned in #14 this should be good to go. The only other thing I’d like to consider in this PR though is making sure that this is documented somehow in the demo site so people know it’s an option. Maybe the generic "a few other styles" link to the CSS file is enough for people to find it in there, but if there’s a good way to include it I think that should be considered too—let me know what your thoughts are :smiley:

palominoz commented 10 years ago

I have found the generic utilities of this library like align-* and pull-*not really useful in my project, just because I prefer to manage on my own those family of classes, in case I need to swap gridism with another library. I think those aren't really needed by gridism users.

It is different for things that are directly linked to the features of the library like no-stacking-on-mobiles or no-gutters, those should be well documented somewhere! Maybe in a more technical page where the visitor is already a gridism user and you can show a nice documentation!

cobyism commented 10 years ago

I’m going to go ahead and merge this in. Anyone reading through the CSS will know it’s there, and there’s not an immediately obvious place to put it in the demo page. Thanks again for the pull! :sparkles: :+1: :cookie: