search

cobyism / gridism

A simple responsive CSS grid.
http://pages.cobyism.com/gridism
MIT License
660 stars 85 forks source link

Added class for fourths #21

Closed rmtsukuru closed 10 years ago

rmtsukuru commented 10 years ago

1/4 width grid sections could only be used with .one-quarter and .three-quarters classes, classes calling them "fourths" have now been added.

cobyism commented 10 years ago

:zap: Thanks for the pull @rmtsukuru! I left a comment with some minor feedback, but I’m totally cool with adding in the ability to use fourth instead of quarter if it reduces the friction for people used to using different wording. Personally, I don’t think I’ve ever spoken or written the word "fourth" when referring to a quarter of something, but I realise others might be more used to things the other way around. :grin:

If you can combine these new classes into the existing rules above them and remove the duplication of the shorthand classes, I’ll merge this in :+1:

aeharding commented 10 years ago

Dang! The alignment will go out of sync on the selectors. :wink:

cobyism commented 10 years ago

@aeharding Yeah, it was a tough call. :crying_cat_face:

cobyism commented 10 years ago

Going to go with @aeharding’s tidy up of this in #22, since it’s ready to go now. Thanks for opening this up though!