cobyism / gridism

A simple responsive CSS grid.
http://pages.cobyism.com/gridism
MIT License
658 stars 85 forks source link

Adding a max-width property to images in units #24

Closed dottorblaster closed 10 years ago

dottorblaster commented 10 years ago

Building a page with Gridism, I saw it did not render the way I wanted. I have put these three lines in my style.css but I believe these should be part of the framework, providing a good responsiveness for pics and "huge" graphic elements.

cobyism commented 10 years ago

:+1: Yeah, I’m fine with this change, however I’d like to suggest a couple of small tweaks:

Once you make those changes, I’ll merge this in. Thanks for the pull! :grinning:

dottorblaster commented 10 years ago

Committed the changes. You were right at all :smile: And, of course, sorry for submitting you code without a line of comment.

cobyism commented 10 years ago

:metal: Thanks! No worries for not having a comment originally—there’s other things in there that I didn’t put comments on, but for things like this I think it’s worth providing a bit of background for people who read the code :+1: Thanks again!