Closed mspanish closed 6 years ago
:cool:, yeah I’m open to adding this, although I don’t think I’d take it any further (i.e. to sevenths etc.). If you can send me a pull request with those changes, I’ll get it merged in :+1:
Sure I'm not exactly sure how to do a pull request - I've also altered my own gridism.css file, but I could use your most recent one to add the changes. I'll google it when I have time and submit the request. I understand not wanting to add more than 6 - really 5 has covered most situations, just have some advanced layouts where I wanted 6 icons visible in a nice row.
@mspanish No worries! The easiest way to make the changes via pull request is probably going to be as follows:
gridism.css
file in this repository, and click "edit". GitHub will automatically create a fork of the project on your account for you to commit your changes to.Here’s an article from GitHub Help describing those steps with screenshots, as well as a couple of GitHub Guides articles that should also help with sending your first pull request:
If you have more questions, don’t hesitate to ask here and I’ll do what I can to help :grinning:
Also, before you make your changes, I just realised one other thing about what you’re proposing. The .two-sixths
, .three-sixths
, and .four-sixths
classes define exactly the same widths as the .one-third
, .half
, and .two-thirds
classes respectively, so the only classes you’d need to add are the .one-sixth
and .five-sixths
classes. Also note that this would be the same as the quarter
classes, where there is no .two-quarters
classes, for example. Does that make sense?
Hey I found myself needing to divide things into 6 - so I added this, seems to work so I thought I'd post it in case anybody else needs something like this!
.grid .one-sixth, .grid .w-1-6 { width: 16.6667%; } .grid .two-sixths, .grid .w-2-6 { width: 33.3333%; } .grid .three-sixths, .grid .w-3-6 { width: 50.0001%; } .grid .four-sixths, .grid .w-4-6 { width: 66.6668%; } .grid .five-sixths, .grid .w-5-6 { width: 83.3335%; }