search

cobyism / gridism

A simple responsive CSS grid.
http://pages.cobyism.com/gridism
MIT License
658 stars 85 forks source link

Re-consider top and bottom margin on .unit elements #7

Closed wjthomas9 closed 11 years ago

wjthomas9 commented 11 years ago

I'd rather add vertical padding if needed than worry about removing it or how it impacts vertical rhythm. What do you think about removing the 10px vertical padding on the .unit element?

.grid .unit {
  float: left;
  width: 100%;
  padding: 10px;
}
cobyism commented 11 years ago

I hear what you’re saying, but I’d much rather ensure that the default classes provide a result that looks okay. I want this to be the kind of tool that someone with no experience or design/type knowledge (or even any enthusiasm to learn/try their hand at typography) can pick up and build a site with with very little thinking. If people have to add in vertical padding themselves, they need to know how to do that sanely in CSS, and they also have to make a mental decision about what a good choice would be—I’d rather this project save them the trouble.

People who know what they’re doing with CSS should be more than capable of removing the padding value (by editing the value in the CSS themselves, or by using the .no-gutters class on a parent element like the <body>), or overriding it with their own rules that define how they want the individual site to look. By providing a value by default, I feel like it’s more likely the project will appear to a wider range of people.

Interesting suggestion though—these are exactly the kind of things that I :heart: thinking about. Until these kind of questions are asked, I can’t really know what aspects of the tool people are having friction with. If enough people using the project bring up things like this as concerns, then I’m definitely open to reconsidering. Keep the suggestions coming! :smile::+1: