Svelte plugin crashing - Githubissues

Jayphen commented 4 years ago

To replicate, npx degit "sveltejs/sapper-template#rollup" test, open the test directory in vim and open a .svelte file.

You will see a notice [coc.nvim] The "svelte" server crashed 5 times in the last 3 minutes..

I'm using the latest versions of both coc and coc-svelte. NVIM 0.4.4

samrocksc commented 4 years ago

I duplicated this with the following settings:

NVIM: 0.5.0 OS: Ubuntu 20.04 vim version: NVIM v0.5.0-nightly node version: v12.18.3 coc.nvim version: 0.0.78-56999634f4 coc.nvim directory: /home/sam/.config/nvim/plugged/coc.nvim term: screen-256color platform: linux

Output channel: prettier

The following error occurs:

Error: Cannot find module 'typescript'
Require stack:
- /home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte2tsx/index.js
- /home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte-language-server/dist/src/plugins/typescript/DocumentSnapshot.js
- /home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte-language-server/dist/src/plugins/typescript/features/CodeActionsProvider.js
- /home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte-language-server/dist/src/plugins/typescript/TypeScriptPlugin.js
- /home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte-language-server/dist/src/plugins/index.js
- /home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte-language-server/dist/src/server.js
- /home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte-language-server/bin/server.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Module.require (internal/modules/cjs/loader.js:1025:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte2tsx/index.js:9:10)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Module.require (internal/modules/cjs/loader.js:1025:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte2tsx/index.js',
    '/home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte-language-server/dist/src/plugins/typescript/DocumentSnapshot.js',
    '/home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte-language-server/dist/src/plugins/typescript/features/CodeActionsProvider.js',
    '/home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte-language-server/dist/src/plugins/typescript/TypeScriptPlugin.js',
    '/home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte-language-server/dist/src/plugins/index.js',
    '/home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte-language-server/dist/src/server.js',
    '/home/sam/.config/coc/extensions/node_modules/coc-svelte/node_modules/svelte-language-server/bin/server.js'
  ]
}
[Info  - 3:31:40 PM] Connection to server got closed. Server will restart.

samrocksc commented 4 years ago

Workaround

If you go to the location of your plugin and npm i -D typescript, this issue is solved.

benwoodward commented 4 years ago

Thanks @samrocksc, that worked for me:

cd ~/.config/coc/extensions/node_modules/coc-svelte npm i -D typescript

samrocksc commented 4 years ago

I'd PR a fix, but i'm still learning how to develop the plugins

henryoliver commented 3 years ago

That solution solved the problem here as well:

cd ~/.config/coc/extensions/node_modules/coc-svelte
npm i -D typescript

Thanks

jesperp commented 3 years ago

I think you can just install it through Plug like this instead:

Plug 'coc-extensions/coc-svelte', {'do': 'yarn install --frozen-lockfile'}

As explained in the Note section here: https://github.com/neoclide/coc.nvim/wiki/Using-coc-extensions#use-vims-plugin-manager-for-coc-extension

davidroeca commented 3 years ago

If this still doesn't work for you, try Plug 'coc-extensions/coc-svelte', {'do': 'yarn install --frozen-lockfile && yarn build'}

davidroeca commented 3 years ago

I think this is a duplicate of https://github.com/coc-extensions/coc-svelte/issues/15. Should have been resolved by https://github.com/coc-extensions/coc-svelte/pull/18

coc-extensions / coc-svelte

Svelte plugin crashing #13

Output channel: prettier

Workaround