Adds no_username_in_x for compatibility with Apple's SRP

cocagne / pysrp

Python implementation of the Secure Remote Password protocol (SRP)

MIT License

113 stars 42 forks source link

Adds no_username_in_x for compatibility with Apple's SRP #40

Closed masihyeganeh closed 4 years ago

masihyeganeh commented 4 years ago

I know this repo is old and has not been updated in years, but I could finally find the difference between this and Apple's SRP implementation in CoreCrypto. Your library is almost 100% compatible with that, except this important option to omit username when calculating x. This won't break anything. It would be great if you could merge it and update pypi. Thanks

cocagne commented 4 years ago

Done. Thanks for the contribution! You may also want to consider updating the documentation in the readme to include a note on your change and how to use it.

jnsgsr commented 3 years ago

@masihyeganeh Hello, did you manage to make it work with "Apple's SRP"?