search

cocagne / pysrp

Python implementation of the Secure Remote Password protocol (SRP)
MIT License
113 stars 42 forks source link

PR: Pythonizing #47

Closed elyashiv closed 2 years ago

elyashiv commented 2 years ago

Hi, I wrapped BN in a class, to provide a cleaner interface. Hope you will also find it more readable.

cocagne commented 2 years ago

Thanks for the patch. What motivated you to write it? This code has been stable for several years now and I'm not sure I want to risk such a substantial change for cosmetic purposes. Was there something beyond that you were seeking to address?

cocagne commented 2 years ago

Closing due to lack of response for the motivation behind this pull request. As it stands I don't think the risk of such a large change to an established code base is worth the benefit of a more pythonic BN interface.