search

cocagne / pysrp

Python implementation of the Secure Remote Password protocol (SRP)
MIT License
113 stars 42 forks source link

Transactionalize #9

Closed nelz9999 closed 9 years ago

nelz9999 commented 9 years ago

This is the candidate work to address Issue https://github.com/cocagne/pysrp/issues/6.

Builds upon PR https://github.com/cocagne/pysrp/pull/8...

Most of the changes are procedural, but the change in https://github.com/OnBeep/pysrp/commit/11ac6ebecde0782cedfbd1543862545c8fb05048 affects the randomness of the ephemeral values by sacrificing a single bit (out of 256) of entropy in favor of enforcing a 32-byte representation.

nelz9999 commented 9 years ago

Also, for symmetry's sake, I added the functionality to both sides: Verifier (bytes_b) and User (bytes_a).

nelz9999 commented 9 years ago

@cocagne Is there anything I can do to ease the integration of this?

cocagne commented 9 years ago

Thanks Nelz. I'm currently attending the Storage Developers Conference and probably won't be able to take a look at your patches for a few more days. I'll let you know as soon as I get the chance.

Tom On Sep 17, 2014 9:53 AM, "Nelz" notifications@github.com wrote:

@cocagne https://github.com/cocagne Is there anything I can do to ease the integration of this?

— Reply to this email directly or view it on GitHub https://github.com/cocagne/pysrp/pull/9#issuecomment-55924391.

cocagne commented 9 years ago

Looks really good overall Nelz. Just a few standard pointer handling issues and memory leaks to address before merging.

nelz9999 commented 9 years ago

I've addressed most of your comments, except for the bit around single- vs. double-pointers, which I commented on above.

(Please pardon my slowness, it's been a LONG time since I've done any C, and I've been super reliant on https://github.com/radii for his C excellence.)

nelz9999 commented 9 years ago

Awesome! Thanks!

cocagne commented 9 years ago

No problem. Thanks for the patch. If you don't see the new version up on pypi in the next couple of days, ping me.

Tom

On Tue, Sep 30, 2014 at 1:09 PM, Nelz notifications@github.com wrote:

Awesome! Thanks!

— Reply to this email directly or view it on GitHub https://github.com/cocagne/pysrp/pull/9#issuecomment-57356779.