search

cocagne / txdbus

Native Python implementation of DBus for Twisted
MIT License
61 stars 38 forks source link

Fixes #52 - Intermittent failures on test_shared_signal. #55

Closed exvito closed 7 years ago

exvito commented 7 years ago

See analysis and comments on #52.

WhyNotHugo commented 7 years ago

Ugh, dammit, I had not activated my virtualenv and was running trial against my locally installed copy. Sorry!

Yes, this works as expected.

exvito commented 7 years ago

IMPORTANT: Please disregard my last PS: review, it is incorrect.

I'm submitting an updated test -- now checking everything and, I hope, easier to understand with improved readability. It is a bit more verbose, though. But I don't see that as something bad. :)

exvito commented 7 years ago

I just pushed onto my issue-52-fix-test-shared-signal branch which originated this PR. Not sure if it ended up here, given that it has been merged and closed -- I can't seem to find any notice of that here... :/

Please take a peek at it here https://github.com/exvito/txdbus/blob/issue-52-fix-test-shared-signal/txdbus/test/client_tests.py#L838 and let me know your thoughts on whether you agree this is a better test (in correctness and readability).

If so, maybe I'll need to issue a second PR, not sure.

Thanks.

WhyNotHugo commented 7 years ago

You'll need to issue a second PR since this one is merged, but I'll go ahead and look at the branch meanwhile.