Closed WhyNotHugo closed 7 years ago
:exclamation: No coverage uploaded for pull request base (
master@95bf032
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #58 +/- ##
=========================================
Coverage ? 89.31%
=========================================
Files ? 13
Lines ? 2144
Branches ? 0
=========================================
Hits ? 1915
Misses ? 229
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 95bf032...6b73585. Read the comment docs.
Good idea. I tried keeping coverage fairly high but often forgot to run trial with the coverage option. Having this done automatically will be a big help. Thanks @hobarrera
Yup. I was surprised that coverage was actually pretty high (especially considering you didn't so actively track it!).
@cocagne I don't think you followed the instructions on this PR's message. ;)
https://github.com/cocagne/txdbus/pull/42#issuecomment-306215451
Yeah, I skipped blocking the codecov-io user. Fixed.
On Mon, Jun 5, 2017 at 11:39 AM, Hugo Osvaldo Barrera < notifications@github.com> wrote:
@cocagne https://github.com/cocagne I don't think you followed the instructions on this PR's message. ;)
42 (comment)
https://github.com/cocagne/txdbus/pull/42#issuecomment-306215451
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cocagne/txdbus/pull/58#issuecomment-306237735, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrLfLvYLF_HxmbBnhbH8LM3i87vCDbWks5sBC8lgaJpZM4NwJ8v .
Thanks!
I think you need to grant codecov access for it to post the status checks.
Hover over / click the checkmark here to see what I'm talking about. That same result would also appear on PRs just next to travis.
Note: You just need to sign in and grant permissions, but you don't need to enable the integration. That's just the bot that posts.
I'm not sure I follow. Where do I grant access for it? Add one of the codecov IDs as a collaborator or something?
On Mon, Jun 5, 2017 at 1:16 PM, Hugo Osvaldo Barrera < notifications@github.com> wrote:
I think you need to grant codecov access for it to post the status checks.
Hover over the checkmark here https://github.com/hobarrera/txdbus/commits/master to see what I'm talking about. That same result would also appear on PRs just next to travis.
Note: You just need to sign in and grant permissions, but you don't need to enable the integration. That's just the bot that posts.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cocagne/txdbus/pull/58#issuecomment-306263077, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrLfOJxdLS52AdeIzNWdSx1PIi7KB0Kks5sBEX8gaJpZM4NwJ8v .
Oh, I think you mostly need to log into their website, and grant them permissions to your public repos (I honestly don't clearly recall since I only did this once for all my repos).
Hmmm. Looks like codecov has access to txdbus, both on their side and from GitHub. I'm not sure what's wrong.
On Tue, Jun 6, 2017 at 9:55 AM, Hugo Osvaldo Barrera < notifications@github.com> wrote:
Oh, I think you mostly need to log into their website, and grant them permissions to your public repos (I honestly don't clearly recall since I only did this once for all my repos).
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cocagne/txdbus/pull/58#issuecomment-306512228, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrLfI-YcEy5RGqSz82YJajT5QYAighEks5sBWhngaJpZM4NwJ8v .
Measure coverage and track how it varies in PRs.
Codecov has an annoying bot that jumps around commenting on issues with some stats. This is generally undesireable. To disable it, two steps need to be taken:
@codecov-io
to blocked users: https://github.com/settings/blocked_users