search

cocagne / txdbus

Native Python implementation of DBus for Twisted
MIT License
61 stars 38 forks source link

Fixes #61 - Skip ...test_long on Python 3 #65

Closed exvito closed 7 years ago

exvito commented 7 years ago

Subject says it all, fixes #61.

Feedback welcome.

WhyNotHugo commented 7 years ago

This does expose another python3-issue: very large numbers need to be treated as INT64 when marshalling to DBus.

On python2, these number were recognizable because they were long. In python, we need to compare them against certain values.

I'll merge this here since it makes sense, but open a new issue for that, since it's completely separate.

WhyNotHugo commented 7 years ago

Oh, looks like that's already covered: https://github.com/cocagne/txdbus/blob/master/txdbus/marshal.py#L245

Not sure what'll happen with numbers that are larger than 64bits though. :(