search

cocagne / txdbus

Native Python implementation of DBus for Twisted
MIT License
61 stars 38 forks source link

Make sure all examples work with all python versions #72

Open WhyNotHugo opened 7 years ago

WhyNotHugo commented 7 years ago

Maybe this could be done via CI, just in case any API changes, etc (I guess we'd have to make the examples a package?).

cocagne commented 7 years ago

Hmmm. That's a good idea. Though I wonder if we could just create unit tests that simply execute those examples and report pass/fail.

On Wed, Jun 7, 2017 at 10:27 PM, Hugo Osvaldo Barrera < notifications@github.com> wrote:

Maybe this could be done via CI, just in case any API changes, etc (I guess we'd have to make the examples a package?).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cocagne/txdbus/issues/72, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrLfClqyM74XWlxYYmVpgbNO8KqhQlIks5sB2odgaJpZM4NziMO .

WhyNotHugo commented 7 years ago

Yup, that would be the idea, but we need some extra work in most cases (eg: the one that fires a signals needs for us to start listening for the signal too).

I'd start out by moving docs/examples/ into /examples, and create examples/__init__.py, though, so they can actually be importable.