search

cocagne / txdbus

Native Python implementation of DBus for Twisted
MIT License
61 stars 38 forks source link

Tests are broken with Python 3.12 on Debian build #96

Open goffi-contrib opened 3 months ago

goffi-contrib commented 3 months ago

Hello,

I'm writing this ticket for the Debian developer maintaining txdbus on this distribution, for some reason they can't publish here.

The Debian build it failing due to some unpacking error: https://ci.debian.net/packages/t/txdbus/testing/s390x/49118708/

From the debian dev:

I guess it is about endianess. s390x is big endian, TTBOMK. Maybe the tests assume (or fallback to) little endian?

Thanks!

goffi-contrib commented 3 months ago

Note: here are the patches used in Debian to fix the issues: https://salsa.debian.org/python-team/packages/txdbus/-/tree/debian/master/debian/patches?ref_type=heads

WhyNotHugo commented 3 months ago

The error states:

 63s AssertionError: b'\x04(ii)\x00\x00\x00\x01\x00\x00\x00\x02\x00\x00\x00' != b'\x04(ii)\x00\x00\x00\x00\x00\x00\x01\x00\x00\x00\x02' : Binary encoding differs from expected value

This definitely sound like the mismatch that one would see when assuming the opposite endianness.

WhyNotHugo commented 3 months ago

All the errors are quads of bytes in inverted order, so definitely an endiannes issue.

goffi-contrib commented 3 months ago

Hello. Is there any plan to fix it soon? The package will be removed from Debian testing because of this unfortunately. Thanks.

cocagne commented 3 months ago

Hopefully I can get to it this weekend. I don't currently have a Linux development machine though so I'll probably need to spin up a new VM. Can you recommend a distro with a 3.12 Python package? I've been out of the Linux game for a while so I'm not sure which distros have it available.

Tom

On Tue, Aug 13, 2024 at 3:44 AM Jérôme Poisson @.***> wrote:

Hello. Is there any plan to fix it soon? The package will be removed from Debian testing because of this unfortunately. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/cocagne/txdbus/issues/96#issuecomment-2285698363, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANMW7CTTRKWW3QBNOUF4C3ZRHBQRAVCNFSM6AAAAABLGWRW2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBVGY4TQMZWGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

goffi-contrib commented 3 months ago

Thanks for your quick answer @cocagne .

According to distrowatch 3.12 is available on Debian testing (Trixie): https://distrowatch.com/table-mobile.php?distribution=debian

WhyNotHugo commented 3 months ago

Alpine 3.20 and ArchLinux both ship Python 3.12.