search

cocalele / PureFlash

A ServerSAN storage system designed for flash device
GNU General Public License v3.0
101 stars 29 forks source link

Give store device a formal and peculiar name #8

Closed cocalele closed 4 years ago

cocalele commented 4 years ago

We have use 'store' as name of a storage device in AFS node. but store is too common a word, and cause chaos in later discussion and documentation. We need a more formal and a peculiar name for store device, like the word ‘OSD’ used in ceph.

geekyang95 commented 4 years ago

Yes. As my suggestion, Call it Node or Instance. And the word store should give to device structure.

I've write some code for new dev_handle_t, maybe we could use the new name. And also for connection, I suggest to use a more comon base class to manage it. Then we can write both Tcp or RDMA as a subclass for it.

cocalele commented 4 years ago

So, as your suggestion, Node as the overall name of s5afs service running on a machine. store to represent a disk( SSD, or HDD, or a loop back device in testing). This is the name currently in use.

OK, let's keep current status.

cocalele commented 4 years ago

So, as your suggestion, Node as the overall name of s5afs service running on a machine. store to represent a disk( SSD, or HDD, or a loop back device in testing). This is the name currently in use.

OK, let's keep current status.

To the continuous of this project, it's better to use the word store for s5afs service, and tray for a single disk(SSD, HDD, etc). These word has already used in code to register on ZK.

Of course, I'll give some explain in the readme doc.

geekyang95 commented 4 years ago

9