Contextmenu should close when expected

cockpit-project / cockpit-files

A Featureful File Browser for Cockpit (Modernized and tested version of https://github.com/45Drives/cockpit-navigator)

GNU Lesser General Public License v2.1

44 stars 26 forks source link

Contextmenu should close when expected #270

Open jelly opened 7 months ago

jelly commented 7 months ago

Right clicking anywhere on the page when a context menu is being displayed should dismiss the menu instead of opening the browser context menu (which is what happens when you right click on the properties area or anywhere not within the grid view)
Opening a menu should dismiss other menus.

Originally posted by @garrett in https://github.com/cockpit-project/cockpit-navigator/issues/254#issuecomment-1934535515

For reference:

The contextmenu comes from Cockpit and only listens on click and the left button.

jelly commented 2 months ago

Cannot reproduce on current main. Screencast from 2024-07-16 14-23-07.webm

garrett commented 2 months ago

Sadly, still a problem. Screencast from right now, from current main:

output_noaudio.webm

jelly commented 2 months ago

Then that's not our bug, it's Patternfly and nothing we should really hack around.

garrett commented 2 months ago

How is this not our bug? You're only supposed to be able to have one menu open at a time in any app. It's supposed to close other open menus when opening a new one.

jelly commented 2 months ago

How is this not our bug? You're only supposed to be able to have one menu open at a time in any app. It's supposed to close other open menus when opening a new one.

Because its a dropdown component of PF, which doesn't seem to close when a user right clicks?

garrett commented 2 months ago

(Native browser menus don't count.)

Elsewhere on Cockpit...

Kooha-2024-07-25-10-43-59.webm