cockpit-project / cockpit-files

A Featureful File Browser for Cockpit (Modernized and tested version of https://github.com/45Drives/cockpit-navigator)
GNU Lesser General Public License v2.1
36 stars 25 forks source link

bookmarks: Rename "Add bookmark"? #657

Open garrett opened 1 month ago

garrett commented 1 month ago

I think the "Add bookmark" label is a bit confusing. I almost thought it would open a new dialog. Something like "Add to bookmarks" (similar to Nautilus) may be better.

Originally posted by @subhoghoshX in https://github.com/cockpit-project/cockpit-files/issues/522#issuecomment-2223347959

garrett commented 1 month ago

Alternatives:

"Bookmark current directory" "Add current directory"

However, the opposite would be "Remove current directory", which sounds like rm -rf, unless it's a really lengthy "Remove current directory from bookmarks".

We're currently using "Remove current directory", so it's either fine enough through context, or we should change that too, to "Remove from bookmarks" (as the opposite to "Add to bookmarks").