cockpit-project / cockpit-machines

Cockpit UI for virtual machines
GNU Lesser General Public License v2.1
281 stars 73 forks source link

Remember State filter settings in Machines interface #1032

Open mister0825 opened 1 year ago

mister0825 commented 1 year ago

In the Virtual Machines interface, after a user filters the view to show only running VMs, the view reverts back to 'All' when navigating away and then back to the interface.

Steps to reproduce:

  1. Filter VM view by 'State: Running'
  2. Switch to the Storage Pools or Networks tab.
  3. Switch back to the main VM view, filter reverts back to 'State: All'

The ask is for the filter settings (regardless of which state is being selected) to be remembered during the active session.

garrett commented 1 year ago

I agree with this suggestion. :+1: Thanks for filing the issue!

We should always remember filtering state like this within Cockpit sessions. (I know we do this in several other places outside of Cockpit-Machines already.) In general, filtering like this should be remembered in the session, but not across sessions.

shaul75 commented 1 year ago

Another one which bugs me is the Console view. "Desktop viewer" is always selected by default (when present), I constantly switch it to serial console, only to be reminded of how tiny the console box is, so I click the "Expand" button which does make it more useable, but at the same time it decides to revert the selection back to "Desktop viewer" 😭

garrett commented 1 year ago

@shaul75: Thanks for additional feedback! I've opened another issue based on your comment.

We're also in the process of redesigning and reimplementing the console and we'll try to make sure this is addressed soon too. The new designs should help improve the the desktop viewer experience as well.