search

cockpit-project / cockpit-machines

Cockpit UI for virtual machines
GNU Lesser General Public License v2.1
289 stars 74 forks source link

Setting VNC password breaks web VNC viewer #1405

Open brandonkal opened 8 months ago

brandonkal commented 8 months ago

This doesn't seem to be completely fixed in cockpit-machines 304-1~bpo22.04.1 (on Ubuntu LTS 22.04 host) To reproduce:

  1. Changing qemu.conf file to include a password and restarting libvirtd.
  2. This breaks existing machines VNC webviewer
  3. Using virsh edit domain I can add a passwd to the vnc XML line but when cockpit starts the VM that is ignored.
  4. Web VNC does display but flashes in and out. This doesn't seem to be an issue when connecting to the VM via Apple VNC viewer with the password.

Also broken is setting qemu.conf to listen on 0.0.0.0 for VNC is not respected by cockpit, it is always 127.0.0.1.

jelly commented 8 months ago

That doens't sound ideal, we have an issue to make this configurable which should also handle the password scenario then. https://github.com/cockpit-project/cockpit-machines/issues/553

However: Cockpit should not change qemu.conf and I am not sure if we want to parse it.