cockpit-project / cockpit-machines

Cockpit UI for virtual machines
GNU Lesser General Public License v2.1
262 stars 68 forks source link

test: Wait for IPv6 address before testing pixels #1614

Closed mvollmer closed 2 months ago

mvollmer commented 2 months ago

So that the picture is stable.

martinpitt commented 2 months ago

Thanks! Do you have a link to an example failure?

mvollmer commented 2 months ago

Thanks! Do you have a link to an example failure?

Here: https://cockpit-logs.us-east-1.linodeobjects.com/pull-1601-922588b7-20240506-093822-fedora-40/log.html

mvollmer commented 2 months ago

(The reference image doesn't have ipv6 in it, so we need to update it. That's why this is Draft.)

mvollmer commented 2 months ago

Huh? Does the IPv6 address actually only show up with os="linux2022"? That doesn't make sense to me right now, but...

mvollmer commented 2 months ago

Huh? Does the IPv6 address actually only show up with os="linux2022"? That doesn't make sense to me right now, but...

Ah, of course, missing change notifications. We have to wait until there is a IPv6 address before switching to the page.

mvollmer commented 2 months ago

Huh? Does the IPv6 address actually only show up with os="linux2022"? That doesn't make sense to me right now, but...

Ah, of course, missing change notifications. We have to wait until there is a IPv6 address before switching to the page.

Ok, the IPv6 link-local address gets reported by the guest agent, and the agent indeed only gets connected by default with linux2022. So, we only need to do this in #1601.