disks: Display source for disks of type "block"

cockpit-project / cockpit-machines

Cockpit UI for virtual machines

GNU Lesser General Public License v2.1

262 stars 68 forks source link

disks: Display source for disks of type "block" #1616

Closed mvollmer closed 2 months ago

mvollmer commented 2 months ago

They have an entry like <source dev="..." />.

mvollmer commented 2 months ago

Test s'il te plaît ? This doesn't seem to be caught by any pixel test either.

Added!

martinpitt commented 2 months ago

Thanks! This new test fails on all Debian/Ubuntu due to AppArmor not allowing access to /dev/loop0. But as it doesn't seem to break the VM startup on the outside (Just that supposedly the guest can't actually access it), I suggest to simply allow that message. There's plenty of precedent like

self.allow_journal_messages(f'.* type=1400 .* apparmor="DENIED" operation="open" profile="libvirt.* name="{self.vm_tmpdir}.*')