search

cockpit-project / cockpit-machines

Cockpit UI for virtual machines
GNU Lesser General Public License v2.1
289 stars 74 forks source link

Add testing support for tumbleweed #1655

Closed Nykseli closed 4 months ago

Nykseli commented 4 months ago

Depends on:

martinpitt commented 4 months ago

There, all blockers resolved.

Nykseli commented 4 months ago

Thanks! We'll fix rest of the things tomorrow :-)

SludgeGirl commented 4 months ago

Alright that should be everything responded to/fixed. Let me know if you want any other changes!

martinpitt commented 4 months ago

Thanks @SludgeGirl -- the commits so far would be acceptable for me. I'd like to replace the AppArmor hack (which looks a bit brittle) with #1658 if possible, but not a blocker.

I triggered the tests (opensuse-tumbleweed, but also all the others to check for regressions), let's hear the bots' opinion! :grin: (testing-farm rawhide failure is known and fixed in #1657, and the f-39 failure was a "WTH?" -- retried)

martinpitt commented 4 months ago

Cool, success! Do you mind pulling in the change from #1658, drop the AppArmor commit, and we re-test with that? If it works, I think we'd both prefer that. Otherwise we land this version. Cheers!

SludgeGirl commented 4 months ago

Yep that all looks good! I've pulled it in, come-on bots let's see that green!

martinpitt commented 4 months ago

works! I landed #1658 and took the liberty to rebase this branch.

martinpitt commented 4 months ago

See https://github.com/cockpit-project/bots/pull/6442

martinpitt commented 4 months ago

yay rawhide :exploding_head:

But the build still worked in an earlier version in commit 2d5893fe85a935041e29888d424f285279e9d20c today, so I'm going to ignore that.

Nykseli commented 4 months ago

@martinpitt Thanks a lot for all the help, once again! :)