search

cockpit-project / cockpit-machines

Cockpit UI for virtual machines
GNU Lesser General Public License v2.1
257 stars 67 forks source link

Makefile: Update Cockpit lib to 06a2f4555e7a6c1e82954f2921cb6f1b #1685

Closed github-actions[bot] closed 3 weeks ago

martinpitt commented 3 weeks ago

This required some mypy yak shaving. Works locally now.

allisonkarlitskaya commented 3 weeks ago

libvirt segfaulting in the VM is pretty unlikely to have been triggered by a tasks container refresh. Let's retry those...

allisonkarlitskaya commented 3 weeks ago

Okay, so one of those cleaned up, but the other one's likely to be a tasks container problem after all:

    raise Error(UNEXPECTED_MESSAGE + "browser errors:\n" + log)
testlib.Error: FAIL: Test completed, but found unexpected browser errors:
error: get os list returned error: "{"problem":null,"exit_status":1,"exit_signal":null,"message":"Traceback (most recent call last):\n  File \"<string>\", line 33, in <module>\nTypeError: 'type' object is not subscriptable"}"
martinpitt commented 3 weeks ago

The type annotation does not yet work on RHEL 8:

error: get os list returned error: "{"problem":null,"exit_status":1,"exit_signal":null,"message":"Traceback (most recent call last):\n File \"\", line 33, in \nTypeError: 'type' object is not subscriptable"}"

Fixed.

martinpitt commented 3 weeks ago

@allisonkarlitskaya note that this isn't a tasks container refresh, but a lib update. I need this for https://github.com/cockpit-project/bots/pull/6491 but cockpit introduced stricter mypy checking, hence the extra commits.