search

cockpit-project / cockpit-machines

Cockpit UI for virtual machines
GNU Lesser General Public License v2.1
257 stars 67 forks source link

test: Add a canary for the last external snapshot issue #1687

Closed mvollmer closed 2 weeks ago

mvollmer commented 2 weeks ago

If the canary triggers, we can remove our workaround.

mvollmer commented 2 weeks ago

The failures were unrelated flakes, retried.

The anaconda-webui revdep test is currently broken because of pixel changes between Cockpit in rawhide and Cockpit main.

mvollmer commented 2 weeks ago

The failures were unrelated flakes, retried.

The anaconda-webui revdep test is currently broken because of pixel changes between Cockpit in rawhide and Cockpit main.

Hmm, wait, the pixel conflicts come from https://github.com/cockpit-project/cockpit/pull/20272 which was released in 318 which is in rawhide. shrug

mvollmer commented 2 weeks ago

The failures were unrelated flakes, retried.

The anaconda-webui revdep test is currently broken because of pixel changes between Cockpit in rawhide and Cockpit main.

Hmm, wait, the pixel conflicts come from cockpit-project/cockpit#20272 which was released in 318 which is in rawhide. shrug

And this is cockpit-machines anyway, sorry, I was confused.

mvollmer commented 2 weeks ago

Thanks, that's nice! The failures were unrelated flakes, retried.

The ubuntu failure seems persistent. I'll check.

mvollmer commented 2 weeks ago

Thanks, that's nice! The failures were unrelated flakes, retried.

The ubuntu failure seems persistent. I'll check.

It's a sorting issue. The test expects test_snap_des to be first in the table, but it isn't when it has the same creation time as test_snap_1. I'll make a PR.