search

cockpit-project / cockpit-machines

Cockpit UI for virtual machines
GNU Lesser General Public License v2.1
257 stars 67 forks source link

Makefile: Update Cockpit lib to a4a114330b8e9d8d52ed514c97e92ec6 #1699

Closed github-actions[bot] closed 1 week ago

martinpitt commented 1 week ago

✘ [ERROR] Could not resolve "dequal/lite"

@jelly @allisonkarlitskaya I think you two already discussed that in a c-files PR? I'll leave these to you

martinpitt commented 1 week ago

AttributeError: 'TestMachinesManifest' object has no attribute 'is_pybridge'

Ah, this got dropped in https://github.com/cockpit-project/cockpit/commit/03a181daaac2b8. We kinda sorta need it for our rhel-8-10 test here, but at this point we can replace it with m.image.startswith("rhel-8") or m.image.startswith("centos-8").

martinpitt commented 1 week ago

Aside from that test failure, I'm fine with explicitly adding dequal for now -- it's a "pick your battles" case, and this isn't worth wasting time on.

martinpitt commented 1 week ago

I'm afraid you accidentally flipped the direction -- it should not appear on the Apps page on RHEL 8. log

martinpitt commented 1 week ago

Sorry, I read this all wrong. This needs some more serious thinking, not just a quick drive-by comment.