search

cockpit-project / cockpit-machines

Cockpit UI for virtual machines
GNU Lesser General Public License v2.1
274 stars 71 forks source link

machines: Modernize Storage Pools design #46

Open garrett opened 3 years ago

garrett commented 3 years ago

It would be better if we reworked the table to be a little more modern.

Originally from https://github.com/cockpit-project/cockpit/pull/15346#issuecomment-779905647:

As deactivation and activation are uncommon, as is deletion, it probably should go into a kebab menu. Additionally, we should try to avoid tabs in expanded tables. If we could show the metadata inline instead of in a key/value pairing (with badge like "labels"), we could have that at the top of an expanded list. And then we could have a secondary list below that.

Like this:

storage-pools-2021-02-16-1545(2)

And the deactivated state could use an empty state pattern when expanded:

storage-pools-2021-02-16-1545(3)

KKoukiou commented 3 years ago

@garrett storage pools can contain more that you show on the mockup, and in that case I am not sure it makes sense to remove the overview. Screen Shot 2021-02-17 at 08 35 48

garrett commented 3 years ago

Sure, but we can use a better layout for it and can still drop the tabs. There's not really much more in your screenshot than what I was showing.

There's a ton of unused space on the side and the page is much more vertical than what's used too, so using tabs here to hide that doesn't make a lot of sense.