cockpit-project / cockpit-podman

Cockpit UI for podman containers

GNU Lesser General Public License v2.1

435 stars 90 forks source link

[feat] render podman container/pod ports as ranges #1839

Closed benniekiss closed 4 weeks ago

benniekiss commented 1 month ago

This PR allows rendering podman container ports as ranges.

It makes sure to only render a range if the range of ports has the same protocol and IP and the host ports are an equivalent range.

This is my first PR in javascript, so please let me know if anything needs fixed!

Closes #1378

Examples: Screenshot_20240829_135103

Show container/pod ports as ranges

jelly commented 1 month ago

CentOS 10 is some RC/Beta issue, triggering the integration tests

jelly commented 1 month ago


# /work/make-checkout-workdir/src/ContainerIntegration.jsx
#   31:42  error  Missing semicolon  semi
#   32:46  error  Missing semicolon  semi
#   33:37  error  Missing semicolon  semi
#   34:39  error  Missing semicolon  semi

eslint fails on missing semicolons, can you add them? Thanks!

jelly commented 4 weeks ago

I've taken the liberty to rebase and squash your changes into one commit as I would like to land it today.

benniekiss commented 4 weeks ago

Great! Thanks for reviewing this and working with me

jelly commented 4 weeks ago

rpm-build:centos-stream-10-x86_64 — RPMs failed to be built.

DNF issues outside of us.