search

cockpit-project / cockpit-podman

Cockpit UI for podman containers
GNU Lesser General Public License v2.1
449 stars 90 forks source link

test: wait on new image tag #1907

Closed jelly closed 1 week ago

jelly commented 2 weeks ago

testDownloadImage flaked a very often as the test succeeds when runs fast enough. Tagging an image to a new name in this case changes the image list name to copybox possibly because it is sorted before my-busybox.

Alternatively we can wait on either?

jelly commented 2 weeks ago

Ding ding ding, fails in some cases still so this needs to be conditional

jelly commented 2 weeks ago

Ah, you are saying the "contains my-busybox" isn't specific enough? But the parent image shouldn't be shown in the "tr", just in the info below. 🤔 This smells funny, and also fails on some OSes. Let's figure out Monday.

The image has two tags, but which one is shown is not predictable which is the issue shown in the failing tests. Either the UI does not update or it is unpredicable.

jelly commented 1 week ago

Cool this works now

martinpitt commented 1 week ago

this looks like flake, /me leans on retry button

jelly commented 1 week ago

Ah, makes sense -- UI has the same order as .RepoTags

Yup, apparently that is not deterministic :D