cockpit 221 breaks cockpit composer (through base1/patternfly.css?)

cockpit-project / cockpit

Cockpit is a web-based graphical interface for servers.

http://www.cockpit-project.org/

GNU Lesser General Public License v2.1

11.36k stars 1.13k forks source link

cockpit 221 breaks cockpit composer (through base1/patternfly.css?) #14229

Closed martinpitt closed 4 years ago

martinpitt commented 4 years ago

Cockpit version: 221

Reproducer:

bots/image-prepare -q fedora-32 && bots/vm-run fedora-32
ssh in, dnf install -y cockpit-composer
log into cockpit, go to "Image Builder"

Composer looks like this:

dnf downgrade cockpit-bridge fixes it, i. e. going back to 220.

This also gets spotted by composer's failing integration tests (this is a Red Hat internal link, sorry).

martinpitt commented 4 years ago

PR #14105 is a likely candidate.

martinpitt commented 4 years ago

Hah, the bug is rather shallow: cockpit-bridge.rpm does not ship patternfly.css at all. If I merely copy it from my built tree into the VM's /usr/share/cockpit/base1/ , composer looks fine again.