cockpit-project / cockpit

Cockpit is a web-based graphical interface for servers.
http://www.cockpit-project.org/
GNU Lesser General Public License v2.1
11k stars 1.1k forks source link

Overview/Metrics reports CPU Critical Temperature instead of Current #18335

Closed jwhaugustine closed 1 year ago

jwhaugustine commented 1 year ago

Explain what happens

Having updated cockpit from version 284 to 285, all of my physical machines running cockpit web interface are now reporting the CPU's critical temperature on the metrics page instead of their actual temperature.

These are all older PowerEdge systems, R210II R420 R620 on Ubuntu Jammy 22.04 server.

Running sensors confirms a display issue:

coretemp-isa-0000
Adapter: ISA adapter
Package id 0:  +46.0°C  (high = +87.0°C, crit = +97.0°C)
Core 0:        +44.0°C  (high = +87.0°C, crit = +97.0°C)
Core 1:        +45.0°C  (high = +87.0°C, crit = +97.0°C)
Core 2:        +46.0°C  (high = +87.0°C, crit = +97.0°C)
Core 3:        +43.0°C  (high = +87.0°C, crit = +97.0°C)
Core 4:        +45.0°C  (high = +87.0°C, crit = +97.0°C)
Core 5:        +40.0°C  (high = +87.0°C, crit = +97.0°C)

coretemp-isa-0001
Adapter: ISA adapter
Package id 1:  +43.0°C  (high = +87.0°C, crit = +97.0°C)
Core 0:        +42.0°C  (high = +87.0°C, crit = +97.0°C)
Core 1:        +40.0°C  (high = +87.0°C, crit = +97.0°C)
Core 2:        +43.0°C  (high = +87.0°C, crit = +97.0°C)
Core 3:        +40.0°C  (high = +87.0°C, crit = +97.0°C)
Core 4:        +41.0°C  (high = +87.0°C, crit = +97.0°C)
Core 5:        +38.0°C  (high = +87.0°C, crit = +97.0°C)

Version of Cockpit

285

Where is the problem in Cockpit?

Metrics

Server operating system

Ubuntu

Server operating system version

22.04.1

What browsers are you using?

Chrome

System log

No response

tomasmatus commented 1 year ago

Thank you for your report, I hope we didn't cause you any inconveniences by alarming that your servers are on fire.

@martinpitt looks like the sensor check was broken in abb9ed4 and sscanf() is satisfied with anything that begins with temp%d when it should only take temp%d_input as a valid temperature sensor.

sch-dmtr commented 1 year ago

Same bug, Dell PowerEdge T130 Screenshot_20230217-105559_Chrome Screenshot_20230217-110551_Termius Screenshot_20230217-111132_Chrome