cockpit-project / cockpit

Cockpit is a web-based graphical interface for servers.
http://www.cockpit-project.org/
GNU Lesser General Public License v2.1
11.28k stars 1.12k forks source link

storage: Provide more guidance for some types of storage (especially disks without a partition table) #19879

Open garrett opened 9 months ago

garrett commented 9 months ago

When running Anaconda from a VM, I realized that it's not obvious what to do when you have a disk without a partition table.

We probably want to make it obvious that a disk doesn't have a partition table, and we might want to consider having a default action to create a partition table. Additionally, in doing so, we probably do not want present much information (like mount partition) and all if people will usually set up a partition table to create partitions which would then be mounted, instead of the entire disk.

So:

  1. Presentation change (to make it more obvious that it does not have a partition table
  2. Action to create a partition table
  3. Revisit the UI for creating a partition table and see if we can make it simpler by default

I think this needs discussion and probably also some design-related work.

garrett commented 9 months ago

For context, when you launch Anaconda's Cockpit Storage integration, it looks like this:

image

This would also be similar to what someone sees on a computer with a blank drive. In many cases, someone would probably just fill the drive with Fedora and skip this step.

However, when someone has multiple disks in Cockpit (like they bought a new disk), I think this is still a UI problem.

We probably want to work on the string for "type" and add a default (secondary) action to the left of the ⋮ menu.

garrett commented 9 months ago

After creating a partition table, we see this:

image

It might still be a good idea to have a default action of a secondary-styled "Create partition" button in the actions area of that row, as that's the only thing you can do with the free space... Aside from leaving it alone.

garrett commented 6 months ago

I made mockups for this.

image

The top is when there's free space on a disk. Having nothing on the disk (not even a partition table) would look similar too (although I guess the dialog could even grow a modern GPT / legacy MBR option, or even really just default to GPT as it's 2024).

But in a Anaconda UI sync call, a decision was made to focus on other features... even though this would improve the UX for people using Cockpit Storage in Anaconda.

I had some alternative ideas on how to display it too, but I'd suggest the above mockups.

image

But, again, it was decided that we have "more important things to work on for now".