search

cockpit-project / cockpit

Cockpit is a web-based graphical interface for servers.
http://www.cockpit-project.org/
GNU Lesser General Public License v2.1
11.2k stars 1.11k forks source link

storage: Improve table accessibility #20471

Open mvollmer opened 5 months ago

mvollmer commented 5 months ago

Hide the icons from screenreaders, and clarify the scope of things.

mvollmer commented 5 months ago

This unfortunately brings back the Patternfly warning.

mvollmer commented 5 months ago

This unfortunately brings back the Patternfly warning.

Fixed with a hack. aria-hidden is stronger than aria-label, at least when looking at the accessibility tree in Firefox.

mvollmer commented 5 months ago

This unfortunately brings back the Patternfly warning.

Fixed with a hack. aria-hidden is stronger than aria-label, at least when looking at the accessibility tree in Firefox.

Replaced with a slightly better hack. Using Td instead of Th...

garrett commented 5 months ago

BTW: It makes sense that aria-hidden overrides aria-label, just like display: none overrides other CSS styling.