cockpit-project / cockpit

Cockpit is a web-based graphical interface for servers.
http://www.cockpit-project.org/
GNU Lesser General Public License v2.1
10.92k stars 1.09k forks source link

re-check/report old packagekit/systemd bugs #20792

Open github-actions[bot] opened 1 month ago

github-actions[bot] commented 1 month ago

Checked 182 URLs out of which 2 is/are invalid: https://bugs.freedesktop.org/show_bug.cgi?id=104552 : Internal Server Error https://bugs.freedesktop.org/show_bug.cgi?id=69575 : Internal Server Error

martinpitt commented 1 month ago

Yes, that server is no more. We can still see them in a web archive:

martinpitt commented 2 weeks ago

The server is back. However, let's still re-test these old bugs, and re-report them against current systemd if necessary -- or give up and just declare that the behaviour.

jelly commented 1 week ago

One re-checked and closed https://github.com/cockpit-project/cockpit/pull/20957

jelly commented 1 week ago

I re-renabled our commented out code:

    // This is what we want to do:
    // systemd_manager.addEventListener("UnitNew", function (event, unit_id, path) {
    //     if (unit_id == name)
    //         refresh();
    // });

And quickly CPU usage goes up and busctl monitor logs tons of dbus requests.

martinpitt commented 1 week ago

Thanks @jelly ! So let's re-report this to the current systemd bug tracker and update the link.

jelly commented 1 day ago

Thanks @jelly ! So let's re-report this to the current systemd bug tracker and update the link.

There is no need for that, this is a known (unfixable?) race in systemd. The solution would be to ignore updates while we get property updates during a refresh().

https://github.com/systemd/systemd/issues/570#issuecomment-125334529