search

cockpit-project / cockpit

Cockpit is a web-based graphical interface for servers.
http://www.cockpit-project.org/
GNU Lesser General Public License v2.1
11.2k stars 1.11k forks source link

test: Don't explicitly go to x0.cockpit.lan in TestIPA #21064

Closed mvollmer closed 4 weeks ago

mvollmer commented 4 weeks ago

x0.cockpit.lan is the name of the local machine, but specifying it with login_and_go will navigate to it as a remote host, using a URL like

https://127.0.0.2:9091/@x0.cockpit.lan

This is not needed since the test only wants the session on localhost, and doesn't care what happens inside the session. It would be harmless except that Cockpit might spontaneously open the "Add host" dialog for "x0.cockpit.lan", which will make the session menu inaccessible for the subsequent logout. (Only on Firefox, Chrome manages to open it anyway.)

mvollmer commented 4 weeks ago

Cockpit might spontaneously open the "Add host" dialog for "x0.cockpit.lan",

This only starts happening with #20826 or #21012, I think...

mvollmer commented 4 weeks ago

Cockpit might spontaneously open the "Add host" dialog for "x0.cockpit.lan",

This only starts happening with #20826 or #21012, I think...

No, seems to be new with #21012, which probably has changed the timing... anyway, it's a good fix. :-)