search

cockpit-project / cockpit

Cockpit is a web-based graphical interface for servers.
http://www.cockpit-project.org/
GNU Lesser General Public License v2.1
11.2k stars 1.11k forks source link

system: Keep DBus connection to tuned open over service state changes #21115

Closed mvollmer closed 2 weeks ago

mvollmer commented 2 weeks ago

This is ok, the DBus service on the other end of a DBusClient can come and go, the DBusClient keeps working.

This avoids closing the DBusClient while it is being used by the rest of the code.

mvollmer commented 2 weeks ago

This is an alternative to #21114. It changes less code and starts the service while the dialog is open (which is nice because we already see the spinner while the service starts.)

mvollmer commented 2 weeks ago

No, this doesn't work, unfortunately. Our DBusClient can survive the owner going away and coming back, but there must be an owner when opening the channel. So it works well with auto-activating DBus services that might get restarted, but not here with tuned. Bummer.