cockpit-project / cockpit

Cockpit is a web-based graphical interface for servers.
http://www.cockpit-project.org/
GNU Lesser General Public License v2.1
11.2k stars 1.11k forks source link

storaged: btrfs: show btrfs filesystem "root" subvolume as "top-level" #21127

Closed jelly closed 12 hours ago

jelly commented 2 weeks ago

Showing this as "/" confuses users as they might think it is the root partition and official btrfs terminology names it "top-level".

https://btrfs.readthedocs.io/en/latest/Subvolumes.html

Relates: #19920


image

jelly commented 2 weeks ago

If we want this italic, it might not be too easy and we have to special case it for btrfs.

garrett commented 2 weeks ago

Two different naive approaches, without much code modification:

This is assuming that "name" is not translated here, however, and that subvolumes are not able to be called "top-level" manually, and that someone has done so.

Is this the best way to do it? I'm sure it's not. It's a way without modifying anything. It might spark some other idea too (perhaps a better way to determine this, as you know the code better), so I'm sharing it.

garrett commented 2 weeks ago

It's still in English as "top-level", at least in https://wiki.debianforum.de/Btrfs :

image

jelly commented 2 days ago

And anaconda PR https://github.com/rhinstaller/anaconda-webui/pull/492