search

cockpit-project / cockpit

Cockpit is a web-based graphical interface for servers.
http://www.cockpit-project.org/
GNU Lesser General Public License v2.1
11.2k stars 1.11k forks source link

shell: Login's close button is not styled like a button #21160

Open garrett opened 6 days ago

garrett commented 6 days ago

image

Spotted in https://github.com/cockpit-project/cockpit/issues/20826#issuecomment-2434802896

The bug is that all action buttons need to look like a button. The exception is "Cancel", which is a link styled button. But this is a "Close" action, which should be styled like a secondary button, not a link.

Bestbynature commented 6 days ago

Hello @jelly and @garrett

I am new to open source contribution. Please how do I proceed to fix this issue?

garrett commented 6 days ago

@Bestbynature: Nice! Hello, and thanks for looking at this!

The button is a link styled button, but should be secondary. Once you've found it in the codebase, you'd need to change the style of button.

PatternFly docs about buttons are at: https://www.patternfly.org/components/button

In other words, <Button variant="link"> needs to be <Button variant="secondary"> for the "Close" button.