tasks: Lots of cleanup - Githubissues

cockpit-project / cockpituous

Cockpit Continuous Integration and Delivery

GNU Lesser General Public License v2.1

36 stars 35 forks source link

tasks: Lots of cleanup #590

Closed martinpitt closed 7 months ago

martinpitt commented 8 months ago

Rendered README: https://github.com/cockpit-project/cockpituous/blob/cleanups/tasks/README.md

[x] Tests blocked on https://github.com/cockpit-project/bots/pull/6035
[x] Blocked on finding a proper solution for #6045 , i.e. getting rid of the old machinery
[x] Rebase after #598, it's going to conflict (textually, not conceptually)
[x] Refresh the container . ~Blocked on https://github.com/cockpit-project/bots/pull/6035 and https://github.com/cockpit-project/cockpit/pull/20149~
[x] Deploy this on OpenShift and validate
[x] Deploy this to rhos/e2e and validate

martinpitt commented 7 months ago

OK, this works now. I adjusted the commit messages, too. However, I'd like to queue it after #598, as it's gonna conflict (a little bit), and is less important.

martinpitt commented 7 months ago

@allisonkarlitskaya This is the "first stage" review -- it may likely get some minor fixups when I deploy it, I just wanted us to agree before I change anything in prod

martinpitt commented 7 months ago

Updated for two issues that I overlooked. The /dev/kvm was a funny one.. I deployed this now, and sent https://github.com/cockpit-project/bots/pull/6079 to confirm both an image refresh and a test run, and it's happy now.

Update: I sent a queue-run fix to https://github.com/cockpit-project/bots/pull/6080 . If that lands soon, I'm happy to revert the revert :grin:

Update 2: Ah, this has to land first. Me refreshing the tasks container now broke bots tests, as they use the new container with the old run-local.sh code. I'll drop /dev/kvm as a follow-up.