search

cockpit-project / console.dot

Webconsole Cloud Service
2 stars 3 forks source link

eliminate websocat from session container #42

Closed martinpitt closed 2 years ago

martinpitt commented 2 years ago

It's not packaged in any distribution. So far the best idea that we had is to replace it with a little Python script that uses the websockets module.

So far we are still using my hacked container from https://github.com/cockpit-project/cockpit/pull/17473 , which includes websocat. But we don't need the two cockpit patches there after all.

We should either add python3 and python3-websocket to the cockpit/ws container, or install cockpit-ws into the appservice container and use the same container both for the appservice and for the sessions. I would prefer the second variant, as that's a bit more efficient on k8s (shared container image) and we retain more control over that. The only downside is that cockpit-ws isn't available in UBI, so we'd need to pull it from our COPR or CentOS Stream.

martinpitt commented 2 years ago

Going to work on that next, as it's fairly similar to the target machine side.

martinpitt commented 2 years ago

Fixed in PR #46