Make /new a POST - Githubissues

cockpit-project / console.dot

Webconsole Cloud Service

2 stars 3 forks source link

Make /new a POST #57

Closed jelly closed 2 years ago

jelly commented 2 years ago

GET requests should be stateless and our specifcation also notes it should be a POST. In the tests a POST can be requested by specifying the data argument, this works the same as urllib's API. Specifying a data parameter automatically makes the request a POST. This will gives us flexibility for when in the future we need to send some data with a POST request.

Closes #31

martinpitt commented 2 years ago

The test run failed, but not due to this PR. I just got the same failure in #58. I'll do a retry, and look at the race.

martinpitt commented 2 years ago

Argh, this does not work on k8s yet: https://issues.redhat.com/browse/RHCLOUD-21408 . So let's revert this for now, and reopen as blocked, so that we have a reminder?

martinpitt commented 2 years ago

Nevermind, this is a generally broken 3scale config.