Closed alimi closed 2 months ago
Just wanted to mention that several ActiveJob adapters for Rails use PostgreSQL and Advisory Locks to work.
Would be great if CockroachDB supported Advisory Locks: https://github.com/bensheldon/good_job/discussions/292
See the Contributing Guide for instructions on running tests.
If the test isn't valid against CockroachDB
test/excludes
that matches the name of the test class if one doesn't already exist. For example to exclude a test fromActiveRecord::AdapterTest
, createtest/excludes/ActiveRecord/AdapterTest.rb
.test_indexes
fromActiveRecord::AdapterTest
: https://github.com/cockroachdb/activerecord-cockroachdb-adapter/blob/c3cb637bd855b36bbf9e76b7947162054b95022e/test/excludes/ActiveRecord/AdapterTest.rb#L1test/cases
. Everything from the ActiveRecord test suite will be available, so a lot of the excluded test can be copied over. Namespace the test under theCockroachDB
module to avoid name collisions. Seetest/cases/adapter_test.rb
for an example.See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48.