search

cockroachdb / c-rocksdb

🚫 DEPRECATED
45 stars 19 forks source link

Use prefix_same_as_start to avoid iteration in FindNextUserEntryInternal. #20

Closed petermattis closed 8 years ago

petermattis commented 8 years ago

This avoids excessive iteration in tombstone fields.

petermattis commented 8 years ago

This is a cherry-pick of https://github.com/facebook/rocksdb/pull/1102.

tamird commented 8 years ago

LGTM. Can you add a patch and hook it up to import.sh? Otherwise we might forget to reapply this when we update rocksdb (since their release cycle lags, and this change won't be in the next 1 or 2 releases).

petermattis commented 8 years ago

Good idea about the patches. Done. Verified by running ./import.sh and nothing changed except build_version.cc.

tamird commented 8 years ago

Nice, thanks for backfilling that other guy, too. Fire away.