Motivated by https://github.com/facebook/rocksdb/issues/1297. Tested to build and pass tests in the main repo after appropriate modifications there to fix the places where they changed their interfaces.
I'd also like to clarify the instructions a little bit in a follow-up PR after chatting with Tamir.
The main issues I ran into are that a bunch of the symbolic links didn't get generated by that loop in import.sh, even after running the loop twice (once when running the script, once outside). I had to run it a third time to get all the symbolic links in place.
Also, I don't understand what's meant by the comment about manually using internal/build_tools/build_detect_platform to update the per-platform flags in cgo_flags. Running that script generates output much different from what's currently in cgo_flags. This is probably just me misunderstanding something.
a-robinson
commented
8 years ago
Motivated by https://github.com/facebook/rocksdb/issues/1297. Tested to build and pass tests in the main repo after appropriate modifications there to fix the places where they changed their interfaces.
I'd also like to clarify the instructions a little bit in a follow-up PR after chatting with Tamir.
The main issues I ran into are that a bunch of the symbolic links didn't get generated by that loop in import.sh, even after running the loop twice (once when running the script, once outside). I had to run it a third time to get all the symbolic links in place.
Also, I don't understand what's meant by the comment about manually using internal/build_tools/build_detect_platform to update the per-platform flags in cgo_flags. Running that script generates output much different from what's currently in cgo_flags. This is probably just me misunderstanding something.
@tamird @tschottdorf
This change is