Enable assertions in race builds

cockroachdb / c-rocksdb

🚫 DEPRECATED

45 stars 19 forks source link

Enable assertions in race builds #27

Closed bdarnell closed 8 years ago

bdarnell commented 8 years ago

See cockroachdb/cockroach#9168

@cockroachdb/stability

tbg commented 8 years ago

LGTM

tamird commented 8 years ago

We need to revert 0cc8a3dd0597a9f92cb0a8a3b60154d09d3cb35a first, right?

petermattis commented 8 years ago

LGTM

bdarnell commented 8 years ago

The parent of this commit is 4.8, so we don't need to revert. We can point the glockfile to this commit (pre-merge) for assertions-enabled 4.8, and the merge of this commit for assertions-enabled 4.9.

tamird commented 8 years ago

Neat.

On Sep 8, 2016 00:44, "Ben Darnell" notifications@github.com wrote:

Merged #27 https://github.com/cockroachdb/c-rocksdb/pull/27.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cockroachdb/c-rocksdb/pull/27#event-781871915, or mute the thread https://github.com/notifications/unsubscribe-auth/ABdsPN82VVEvi5lepsUZOa_pQ9h9Dt8Eks5qn5K2gaJpZM4J3ECD .